[dotnet] [bidi] Implement Permissions extension module #15421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Aside from providing the This fulfills the ask in the issue to do: var permissions = await driver.AsBiDiPermissionsAsync(); However, anyone can extend the |
This was referenced Mar 14, 2025
nvborisenko
reviewed
Mar 15, 2025
|
|
||
| namespace OpenQA.Selenium.BiDi.Extensions.Permissions; | ||
|
|
||
| public class PermissionsBiDi : BiDi |
Member
There was a problem hiding this comment.
It should not derive from BiDi.
nvborisenko
requested changes
Mar 30, 2025
Member
nvborisenko
left a comment
nvborisenko
left a comment
There was a problem hiding this comment.
I guess this one we don't want conceptually.
github-actions
bot
added
the
J-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Permissions WebDriver BiDi module.
Reliant on #15420
Motivation and Context
Fixes #15329
Types of changes
Checklist